docs: Character Kits, Face Rig, and cutout dialogue - #26
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
Document the workspace Character Kit library, Face Rig overlays, cutout dialogue cadence, and recipe inventory. Cross-link 3D Video / README and record Director pipeline pagination plus the stale Scene→Recipe audit. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
IAnMove
approved these changes
Aug 31, 2026
IAnMove
marked this pull request as ready for review
August 31, 2026 21:13
This was referenced Sep 2, 2026
Owner
|
Superseded by #94, which is already on Closing and keeping the branch. |
Owner
|
Closed as superseded by #94. Branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs added/updated
docs/character-kits/HOWUSEIT.md— operator guide for workspace Character Kits, Face Rig, mouth packs, and cutout dialogue.docs/HOWUSEIT.mdindex,docs/3d-video-compositor/HOWUSEIT.md§5.9, and README Character Creator / 3D Video entries.app/docs/API.mdwith Character Kit HTTP + Director list pagination.docs/workspaces/HOWUSEIT.mdsoGET /api/v1/director/pipelinespagination (limit/offset, UI page size 8) is documented.docs/scene-recipe-gap.md: a Scene→Recipe serializer now exists (ui/src/lib/sceneToRecipe.ts); the T2.3 counts are a snapshot.Codepaths covered
app/services/character_kit_library.py,GET/PATCH/DELETE /api/v1/character-kits/library…POST /api/v1/character-kits/face-rig/cleanup(rembgU2Net, never overwrites source)ui/src/lib/characterKit.ts,characterKitFaceRig.ts,characterKitHandoff.tsui/src/lib/cutoutDialogue.ts→scene.dialogueBeats+ recipeAPPROVED_CHARACTER_KITGET /api/v1/director/pipelines?limit=&offset=(limit=0still returns the full scan)Knowledge gaps addressed
409).lookNotesis stripped on save (normalize_character_kit).dialogueBeats; do not mix kit identities.limitre-parses every pipeline JSON.Verified against
tests/test_character_kit_library.py(7 passed) and UI kit/dialogue tests (39 passed). Documentation-only; no runtime change.